Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove Error and Deploy from ModuleConfig #3033

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

matt2e
Copy link
Collaborator

@matt2e matt2e commented Oct 8, 2024

Remove things from ModuleConfig in preparation for language plugins:

  • ModuleConfig.Errors
    • Removed logic to ever write errors to disk (except Java plugin, which just hardcodes errors.pb until it moves to being an external plugin)
  • ModuleConfig.Deploy
    • This has been refactored to being part of a build result. This also allows language plugins to dynamically include files to deploy.

@matt2e matt2e requested review from a team and alecthomas as code owners October 8, 2024 05:56
@matt2e matt2e requested review from a team and wesbillman and removed request for a team October 8, 2024 05:56
@ftl-robot ftl-robot mentioned this pull request Oct 8, 2024
@matt2e matt2e force-pushed the matt2e/strip-down-config branch from 6f29db2 to cfa691c Compare October 8, 2024 05:57
@matt2e matt2e marked this pull request as draft October 8, 2024 05:58
@matt2e matt2e changed the title chore: remove Error and Deploy from ModuleConfig feat: remove Error and Deploy from ModuleConfig Oct 8, 2024
@matt2e matt2e force-pushed the matt2e/strip-down-config branch from 8892fac to 1bb6e05 Compare October 8, 2024 21:51
@matt2e matt2e marked this pull request as ready for review October 8, 2024 21:51
@matt2e matt2e merged commit ab85336 into main Oct 8, 2024
95 checks passed
@matt2e matt2e deleted the matt2e/strip-down-config branch October 8, 2024 21:59
@matt2e matt2e mentioned this pull request Oct 9, 2024
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants